PoC embedded list #4852
Open
PoC embedded list #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick and dirty implementation of embedded list
|
In one of our projects we've implemented a "ControllerIndexView" based on a gist that was floating around. I believe this is basically the same feature? I'll ask around when/if we could actually push back changes since it's a mix and match with things going slightly outside of the scope of EA, but could be patched back in, since a few of these just have to do with going around possible limitations. |
|
I attempted a new approach that seems more elegant to me (although it requires esi and a tiny bit of js): phcorp@1f9aea2 |
|
@phcorp great work ! Could you update your PR with your latest changes ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick & dirty implementation of embedded list.
This PR should not be merged as is. It may be used as a basis for considering the implementation of embedded lists.