Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filters on nested properties #4882

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Use filters on nested properties #4882

wants to merge 1 commit into from

Conversation

Marcachips
Copy link

This PR makes filters support properties with dot notation by using a new filter as wrapper.

  • The NestedConfigurator is able to configure the wrapped filter by (re)invoking the configurators collection and copy configured FormType and options to display the correct wrapped filter view.

  • The NestedFilter is able to apply required left joins for a given path and delegate query customization to wrapped filter by recreating adapted arguments (like FilterDataDto and EntityDto)

There is no tests for now, but i can add it if you are interested by the purpose.

@Marcachips
Copy link
Author

Closes #4881

@javiereguiluz javiereguiluz added this to the 4.x milestone Dec 17, 2021
@npotier
Copy link

npotier commented Dec 21, 2021

Thanks @Marcachips for this PR 👍

This was referenced Dec 23, 2021
Closed
Closed
@Ang3 Ang3 mentioned this pull request Jan 15, 2022
Closed
@DylanKas
Copy link

This PR is really interesting and can be very useful. Is there any plan to merge it ?
Does it need some adjustment or help ?

@Ang3
Copy link
Contributor

Ang3 commented Apr 20, 2022

Hi,

Any news about this feature?.. We still cannot use filters on embedded properties...
Please review priorities, I think this is a primary feature, more than light/dark mode or others front enhancements...
Many PR's about it for months and nothing. :(

@quentint
Copy link
Contributor

Hey there, currently facing an issue this PR would fix, merging would be really great.

Is there anything I/we can do to help?

@25matt12
Copy link

Is there any reason this PR is still not merged ? It would be great to have the possibility to filter on nested properties !

@kiler129
Copy link
Contributor

kiler129 commented Jan 6, 2023

I think the most important thing here are missing tests - I doubt @javiereguiluz will merge it without them.

@tonyellow
Copy link

same here, would be nice if it will be merged.

@msphn
Copy link

msphn commented Jan 17, 2023

@Marcachips will you add tests or do you need help?

@Marcachips
Copy link
Author

I plan to write tests before the end of this week. I don't need help for now, but thanks 👍

@tonyellow
Copy link

@kiler129 i know but this one doesnt work wost nested entities, like product.category

@Marcachips Marcachips force-pushed the feature/nested-filter branch 2 times, most recently from 79c1acd to cec6ecc Compare January 23, 2023 08:45
@Marcachips Marcachips force-pushed the feature/nested-filter branch from cec6ecc to af0bb9f Compare January 23, 2023 08:50
@Marcachips
Copy link
Author

Tests are pushed !

@kiler129 kiler129 mentioned this pull request Jan 29, 2023
Closed
@Snowbaha
Copy link

Hello, your PR looks very nice, what are the "blocked point" now?

@mathis-ait
Copy link

Hello, this PR will be very helpful

b1rdex
b1rdex reviewed Mar 1, 2023
View reviewed changes
src/Filter/NestedFilter.php
/** @var FilterInterface */
private $wrappedFilter;

public static function new(string $propertyName, string $label = null): self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason for this method to be present, it just confuses more. There is no new() method in FilterInterface, so I think this should be removed.

Also, I see a point in renaming wrap() to new() to make it more natural alongside with other filters.

src/Filter/NestedFilter.php
/**
* @author Brandon Marcachi <[email protected]>
*/
final class NestedFilter implements FilterInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate a bit: can this be implemented without adding NestedFilter? Why you chose this way?

For me, it looks much more natural to not have a wrapper for filters – similar to Fields. Just add a dot to filter and you're done... Isn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for the PR and the review. Not sure but I think it's much more complex than just add a dot tbh. Otherwise I really don't understand why this feature is not already implemented. I did a PR for that job and I had to modify much more files to handle all cases due to internal mechanism : #4840

@astronati
Copy link

Any news about this PR?

@fdiedler
Copy link

fdiedler commented Aug 6, 2023

@Marcachips @javiereguiluz Any news for this great feature ?
I need this feature in my current project :)
Thanks

@Marcachips
Copy link
Author

Hello @javiereguiluz !
Can we get visibility into the progress of this Pull Request ?
Do I need to take any additional actions ?

@wehostadm
Copy link

Ping of this great feature @javiereguiluz @Marcachips
Hope it will be merged soon :)

@Quentin-Sch
Copy link

Ping ?

@Sa-Lat
Copy link

Sa-Lat commented Oct 18, 2023

i would also like to have it fixed to get my filter working as intended ♥

@speller speller mentioned this pull request Nov 13, 2023
Closed
@MrJuliuss
Copy link

Hi, up ?

@BrunoJunior
Copy link

@javiereguiluz Some news about this PR ? Thanks

@d3pendent
Copy link

I would also welcome this feature.

@JesusRedGar
Copy link

No news on this one?

@teklakct
Copy link
Contributor

teklakct commented Jun 9, 2024 •
edited
Loading

If you cannot wait for this MR please check my naive implementation.
You only need to add 2 files to your source code.

https://gist.github.com/teklakct/ed154ccadc18b1463a139f09d3286355

Works with v4.9.4

PS. I think there is an option to slightly enhance the EasyCorp\Bundle\EasyAdminBundle\Factory\FilterFactory and achieve similar behavior. I will try to check this someday.

@ToshY
Copy link

ToshY commented Dec 31, 2024

Just got notifications that related issues have been automatically closed (#4881 (comment), #4966 (comment)), so I'm not sure if this will get merged anytime soon 🙁.

@javiereguiluz
Copy link
Collaborator

@ToshY we're closing many old issues automatically ... for PRs, I'll review them manually to see if they are still relevant and if we can reuse parts of them.

@ToshY
Copy link

ToshY commented Dec 31, 2024 •
edited
Loading

@ToshY we're closing many old issues automatically ... for PRs, I'll review them manually to see if they are still relevant and if we can reuse parts of them.

@javiereguiluz Thanks for the clarification. It would still be nice to have a PR like this getting merged.

@johndodev
Copy link

johndodev commented Jan 23, 2025 •
edited
Loading

up, I think it's a must have.
Don't know about the PR but The @teklakct solution is woking well and seems relatively simple :
#4882 (comment)

@finnef
Copy link

finnef commented Feb 3, 2025

I did not have time to do things properly in a fork and PR, but here is the rerolled patch to apply to EA 4.24 to enable the NestedFilter.

ea-filters-nested-properties.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1rdex b1rdex b1rdex left review comments

@Ang3 Ang3 Ang3 left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.