[FEATURE] Breadcrumb implementation #5790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksn135
changed the title
asispts
suggested changes
Jun 23, 2023
| @@ -19,4 +19,4 @@ jobs: | |||
| - name: PHP-CS-Fixer | |||
| uses: docker://oskarstark/php-cs-fixer-ga | |||
| with: | |||
| args: --diff --dry-run | |||
| args: --config=.php-cs-fixer.dist.php --diff --dry-run | |||
There was a problem hiding this comment.
Could you please remove/revert syntax style fix and keep only the added feature? This will simplify the review process. The syntax has already been fixed in #5803. Thank you!
phpstan-baseline.neon
Outdated
Comment on lines
2
to
27
| treatPhpDocTypesAsCertain: false | ||
| ignoreErrors: | ||
| - | ||
| message: "#^Parameter \\#1 \\$message of class EasyCorp\\\\Bundle\\\\EasyAdminBundle\\\\Translation\\\\TranslatableChoiceMessage constructor expects Symfony\\\\Component\\\\Translation\\\\TranslatableMessage, Symfony\\\\Contracts\\\\Translation\\\\TranslatableInterface given\\.$#" | ||
| count: 1 | ||
| path: src/Field/Configurator/ChoiceConfigurator.php | ||
|
|
||
| - | ||
| message: "#^Call to an undefined method Symfony\\\\Contracts\\\\Translation\\\\TranslatableInterface\\:\\:getDomain\\(\\)\\.$#" | ||
| count: 1 | ||
| path: src/Translation/TranslatableMessageBuilder.php | ||
|
|
||
| - | ||
| message: "#^Call to an undefined method Symfony\\\\Contracts\\\\Translation\\\\TranslatableInterface\\:\\:getMessage\\(\\)\\.$#" | ||
| count: 1 | ||
| path: src/Translation/TranslatableMessageBuilder.php | ||
|
|
||
| - | ||
| message: "#^Call to an undefined method Symfony\\\\Contracts\\\\Translation\\\\TranslatableInterface\\:\\:getParameters\\(\\)\\.$#" | ||
| count: 1 | ||
| path: src/Translation/TranslatableMessageBuilder.php | ||
|
|
||
| - | ||
| message: "#^Variable method call on Twig\\\\Extension\\\\RuntimeExtensionInterface\\.$#" | ||
| count: 1 | ||
| path: src/Twig/EasyAdminTwigExtension.php |
There was a problem hiding this comment.
This unrelated to the current PR. Should be reverted.
|
@asispts done. |
…minBundle into feature-breadcrumb
|
any news? |
sikatikenmogne
approved these changes
Jun 17, 2024
|
any news about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a detailed feature description, see issue #5789