Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): Add Country, Currency and Timezone filters #5834

Draft
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

ndench
Copy link
Contributor

@ndench ndench commented Jul 12, 2023

Draft PR to go along with #5835

TODO (if we want to move forward with this feature request):

  • Support other comparison types (NEQ, CONTAINS, etc)
  • Support multiple choices
  • Allow limiting the available countries/timezones/currencies
  • Write tests

@javiereguiluz
Copy link
Collaborator

@ndench thanks for proposing this feature. I like it and I'll help you with anything you need to complete this.

From the list of things to do, I'd say that:

  • Support other comparison types (NEQ, CONTAINS, etc): Nice to have if not very complex
  • Support multiple choices: Nice to have if not very complex
  • Allow limiting the available countries/timezones/currencies: Let's leave it for the future unless trivial to implement
  • Write tests: Not mandatory to merge this, let's do it only if not very complex

Thanks!

@javiereguiluz javiereguiluz added this to the 4.x milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants