Add default locale to all pretty routes #6754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for an issue I'm having in tests with a multilingual app using pretty urls. The issue does not occur when using old urls. My issue is that I had the following error when generating urls in tests using
CrudTestUrlGenerationtraitThis exception is thrown in UrlGenerator when no locale is found in route defaults, request context or parameters.
When NOT using pretty urls, the
_localeis present in route defaults, but when using pretty urls there is no locale.The PR adds the default
_localefor all routes generated by EasyAdmin.