Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/6598 pretty urls and selected menu item #6771

Open
wants to merge 4 commits into
base: 4.x
Choose a base branch
from
Open

Fix/6598 pretty urls and selected menu item #6771

wants to merge 4 commits into from

Conversation

a-r-m-i-n
Copy link
Contributor

This PR contains several commits:

  • First some improvments and updates for the DDEV environment
  • and it enables the use of pretty urls in example assets of DDEV environment
  • then it contains the first bugfix, regarding additional queryparams in MenuItemMatcher
  • and finally it solves an absolute vs. relative URL issue for Dashboard menu items

This PR fixes #6598

@a-r-m-i-n
[TASK] Update DDEV environment
3b68b50 
- update used MariaDB version to 10.11
- use Symfony framework in version 7.2
- create symlinks for example entities, form and controller instead of copy them
- add final clear cache in setup
- fix "ddev run-tests" command to handle existing but outdated composer.lock file
@a-r-m-i-n
[TASK] Add use of pretty urls in DDEV environment
fa84273 
also added filter in BlogArticleCrudController for category

Relates: EasyCorp#6598
@a-r-m-i-n a-r-m-i-n force-pushed the fix/6598-pretty-urls-and-selected-menu-item branch 2 times, most recently from 57ec69a to 3ed8821 Compare January 29, 2025 14:28
@a-r-m-i-n
[BUGFIX] Add third phase in MenuItemMatcher which ignores all query p…
d8bb908 
…arams

Relates: EasyCorp#6598
@a-r-m-i-n
[BUGFIX] Remove hostname of menu-item before matching
3ed8821 
Depending on its configuration, Dashboards use absolute urls, including the hostname.
For matching this hostname is being removed, always.

To be able to match dashboard URLs, the hostname of menu-item link URL is also removed, when given.

Relates: EasyCorp#6598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pretty URLs and selected menu item
1 participant
@a-r-m-i-n