Fixing issue #6817 (failed to match named routes). #6828
Conversation
| @@ -294,6 +294,26 @@ private function getSymfonyControllerFqcn(Request $request): ?string | |||
| // sub-url or sub-path - using the HTTP header x-forwarded-prefix) | |||
| $url = $this->urlGenerator->generate($routeName, $routeParams, UrlGeneratorInterface::RELATIVE_PATH); | |||
|
|
|||
| // Now, forge the "absolute" path so that it can be matched to a route. | |||
There was a problem hiding this comment.
Just asking: if this code is neede to take care of localized URLs ... couldn't this be fixed if we do something like:
+$routeParams = array_merge($routeParams, ['_locale', $request->attributes->get('_locale')])
$url = $this->urlGenerator->generate($routeName, $routeParams, UrlGeneratorInterface::RELATIVE_PATH);There was a problem hiding this comment.
I did not test it, but I guess it might have worked.
Nevertheless, I think that trying to match a relative path to a route is not a good idea, because the relative path will actually be considered as an absolute one by the matcher (e.g. if the path is ../path, it will be treated as /../path by the matcher (because that is what is returned by getPathInfo()). At least that's what I have seen from my dumps.
I searched a little in Symfony's code, and I found that they actually compute the path we want, and then is is modified either to a relative one or to a full url with the base path here https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Routing/Generator/UrlGenerator.php#L255 . They do this :
if (self::RELATIVE_PATH === $referenceType) {
$url = self::getRelativePath($this->context->getPathInfo(), $url);
} else {
$url = $schemeAuthority.$this->context->getBaseUrl().$url;
}I am pretty sure that the initial value of $url is exactly the path we are looking for, so we have to compute it back. I did it by (trying to) reverse the part where they compute the relative path, and what has been merged reverses the else part instead (note : when using ABSOLUTE_PATH and not ABSOLUTE_URL, the $schemeAuthority should be empty, hence the solution is valid if $this->context->getBaseUrl() returns the same thing as $request->getBasePath(), which seems to be the case.
I feel like it would be nice to actually be able to retrieve the path without the prefix with another constant for instance (ABSOLUTE_LOCAL_PATH ?), but we would need to modify this in Symfony, which is out of our scope.
No description provided.