Rewrite map fixes #3324
Merged
Rewrite map fixes #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a more robust way of identifying TILE_BLOCKS. This fixes the issue where most of lower tiles were not being aplied. - Reduced an output warning that repeated itself twice.
- Fixed wrong IDs - Fixed wrong Layer assertion - Added a conditional branch to protect IDs from overflowing.
|
Web version for easier testing: |
Ghabry
approved these changes
Jan 7, 2025
|
Almost there. Lacks diagonal mix between tiles A and B (1st img is maniacs, 2nd is ours): |
That solves some errors related out of bounds access. Sometimes it happens when drawing a tile, others when checking passability. It may differ from how maniacs deals with this (I suspect maniacs have an extra blank tile, with locked passability, just for OOB tiles).
fdelapena
approved these changes
Jan 16, 2025
|
I don't feel like messing with the diagonal tiles, I'm having a hard time understanding what need to be done. So, I'm ok with aproving it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issues described at #3323
Also I Discovered one last quirk, from toggling autotiles ON/OFF:
This Quirk is not a dealbreakers, so didn't look at the code of it yet.
Things are now very closer to the Maniacs version now, only missing that fix and the AB lower tiles support.