Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inih and lhasa #150

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add inih and lhasa #150

merged 4 commits into from
Nov 10, 2023

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Jul 27, 2023

inih is to get rid of vendoring in liblcf (alternative is using a different ini library).

lhasa is for EasyRPG/Player#3033
Already tested the library on Linux and Windows.

vcpkg package submitted: microsoft/vcpkg#32793


had to add meson here. The "/dev/null" hack appears to work except for emscripten.

not tested on macOS yet

@Ghabry
Copy link
Member Author

Ghabry commented Oct 25, 2023

this builds now on all our relevant platforms.

Just the vcpkg port is missing (is awaiting merge).

@Ghabry Ghabry marked this pull request as ready for review October 25, 2023 23:07
Based on a patch by @MonokoTech
Thanks!
Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@carstene1ns carstene1ns merged commit b1cd6de into EasyRPG:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants