Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add a search option #79

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carstene1ns
Copy link
Member

Will be useful later for the (static) blog and wiki.

Search is running on the client. Data is preprocessed by nanoc.
This makes it fast and not resource hungry.

I have added the whole blog locally and the json data is still smaller than one screenshot... ;-)

@carstene1ns
Copy link
Member Author

carstene1ns commented Apr 18, 2022

You can try it here: https://ci.easyrpg.org/job/website-pr/ws/output/search/index.html

The links are broken, since i do not add the (changed) base-url. This could be fixed later.

https://ci.easyrpg.org/job/website-pr/ws/output/search/index.html?q=player -> even permalinks work.

@carstene1ns
Copy link
Member Author

Rebased on the netlify PR.

https://deploy-preview-79--easyrpg.netlify.app/search/?q=player

@Ghabry
Copy link
Member

Ghabry commented Apr 18, 2022

This works pretty well imo 👍 . Wouldn't have expected that searching can be possible on a static page.

Only thing missing is a way to reach the search.

A later PR could also add a preview feature to indicate where the search result was found with adjacent text for context

@carstene1ns
Copy link
Member Author

Should be more visible now.

@Ghabry
Copy link
Member

Ghabry commented Jun 26, 2022

Was there anything missing here? I simply forgot about it. 😅

Only change I would suggest is moving the search icon into the header after "Contact" because currently it is not possible to search while on the main page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants