-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add a search option #79
base: master
Are you sure you want to change the base?
Conversation
|
4f17730
to
c7a7203
Compare
Rebased on the netlify PR. https://deploy-preview-79--easyrpg.netlify.app/search/?q=player |
This works pretty well imo 👍 . Wouldn't have expected that searching can be possible on a static page. Only thing missing is a way to reach the search. A later PR could also add a preview feature to indicate where the search result was found with adjacent text for context |
c7a7203
to
d2779d0
Compare
Should be more visible now. |
Will be useful later for the (static) blog and wiki based on https://chodounsky.com/2015/05/14/full-text-search-on-static-website/
d2779d0
to
3758138
Compare
Was there anything missing here? I simply forgot about it. 😅 Only change I would suggest is moving the search icon into the header after "Contact" because currently it is not possible to search while on the main page. |
Will be useful later for the (static) blog and wiki.
Search is running on the client. Data is preprocessed by nanoc.
This makes it fast and not resource hungry.
I have added the whole blog locally and the json data is still smaller than one screenshot... ;-)