Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return false when use single radio/checkbox #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rabbitom
Copy link
Contributor

@rabbitom rabbitom commented Sep 4, 2021

fix #3

Copy link
Member

@TechQuery TechQuery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码提交前执行一下格式化程序;
创建 pull request 后设置一下 reviewer,否则仓库管理者收不到通知。

Comment on lines +198 to +199
else {
if(data[name] === undefined)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以连成一个 else if 吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你自己改吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你自己改吧

现在可以把 GitHub 仓库网址中的 .com 改成 .dev,就可以启动 GitHub CodeSpaces(网页版 VS Code),能装 Prettier 等插件。本地不装环境,改一些小代码还是挺方便的。

@rabbitom
Copy link
Contributor Author

rabbitom commented Oct 3, 2021

代码提交前执行一下格式化程序; 创建 pull request 后设置一下 reviewer,否则仓库管理者收不到通知。

  1. 之前没格式化是因为clone代码后没装依赖,husky脚本没有安装。
  2. 执行格式化后报一个类型错误,和本次修改无关的,你看一下:globalThis.crypto = new Crypto();

@TechQuery
Copy link
Member

  1. 之前没格式化是因为clone代码后没装依赖,husky脚本没有安装。
  2. 执行格式化后报一个类型错误,和本次修改无关的,你看一下:globalThis.crypto = new Crypto();
  1. VS Code 装了 Prettier 扩展,它会读取本项目的配置来格式化。
  2. 这个类型错误是升级到 TypeScript 4.4 后出现的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: no value when use single radio or checkbox in form
2 participants