Update meteo stations #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable, I will need to recalibrate the lakes before merging the request. Do you forsee any additional edits to the file that would mean it could make sense to wait to recalibrate? |
|
I don't think I will have time to do any further work on this this year. Maybe I can check more things next year. So from my side you can do a recalibration but it is also not urgent because I am not currently using the results of the simulations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You used an older version of Lakes.json so I had to update quite a few of the stations. This is by no means a definite file. Maybe a closer look at all meteo stations used (and potential alternatives) could make sense. However, it seems to me that the changes induced by changing the meteo station for a simulation were not that big. Hence, I often opted for a meteo station with a longer data record (e.g. from Thun to Interlaken and from Egolzwil to Lucerne).