Added modal #169
Merged
Added modal #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecdar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Asking @DenFlyvendeGed have you decided that implementing close/open functionality as a svelte store is too complex? I would prefer it that way, but I can accept this as well. |
I'll do it |
christian140398
previously approved these changes
Dec 14, 2023
|
It is okay to delete the three tests because they specifically test the custom open/close functionality that we have removed by moving the settings view to the modal. We should however implement tests that check the same functionality in the modal. |
christian140398
approved these changes
Dec 14, 2023
BaBrixx
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes/Additions:
Closes #79