Refactor automaton + refactor file loading + add example projects + add recent projects #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecdar ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atjn
changed the title
atjn
added a commit
that referenced
this pull request
Nov 16, 2023
These annotations are not necessary, as they are already written in typescript. If we change anything in this file, it will cause a major merge conflict with #99
BaBrixx
added a commit
that referenced
this pull request
Nov 17, 2023
* Using AbortController and PointerCapture correctly. Also updated comments. * Revert changes in svgview These annotations are not necessary, as they are already written in typescript. If we change anything in this file, it will cause a major merge conflict with #99 --------- Co-authored-by: Nyby <[email protected]>
atjn
changed the title
Co-authored-by: Albert Hald <[email protected]>
Fixes a few bugs so projects are loaded correctly now. Also made a few changes to make the adapter usable outside of the browser context.
A few fixes to make it easier to use the automata
Co-authored-by: Albert Hald <[email protected]>
atjn
changed the title
…-GUI-Web into automaton-refactor
TSKsmiley
previously approved these changes
Nov 29, 2023
TSKsmiley
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a bunch of improvements to the automaton structure:
It also introduces a standardized format for loading and saving projects. Previously, this was hard coded into each adapter.
The format includes a standard JSON format for an entire project, and a standardized structure to map that JSON file to/from the file system.
Finally, it introduces example projects and recent projects. Example projects are bundled from
Ecdar-Commonand make it easy to get started with a project. Recent projects is a list of previous projects that the user can click on to instantly load a project they were working on.I am aware that this is a massive PR, I am very sorry. All of these functions are tightly coupled and thus have a big influence on how the others should be implemented. I found that it was very hard to build them separately, so I combined them instead.
Closes #105
Closes #106
Closes #82
Closes #137
Closes #138
This work is blocking a lot of other work, so we have decided to merge it now, despite it missing a few things: