Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotient getNextMoves assumes that location runtime instance #71

Closed
Brandhoej opened this issue Sep 13, 2022 · 1 comment · Fixed by #74
Closed

Quotient getNextMoves assumes that location runtime instance #71

Brandhoej opened this issue Sep 13, 2022 · 1 comment · Fixed by #74
Labels
bug Something isn't working

Comments

@Brandhoej
Copy link
Contributor

Brandhoej commented Sep 13, 2022

For rules 9 and 10 it is assumed that the locationin getNextMoves is as instanceof either InconsistentLocation and UniversalLocation this assumption does not hold for tests such as doubleQuotientTest2, doubleQuotient3 and other tests with double quotients. I believe we might need a single Location type or keep it consistent in such a way that we don't have to make a "double check" to figure out whether a location is inconsistent and such. I have opened another issue focusing on the Location class #72.

@Brandhoej Brandhoej added the bug Something isn't working label Sep 13, 2022
@Brandhoej Brandhoej mentioned this issue Oct 2, 2022
@Brandhoej Brandhoej linked a pull request Oct 2, 2022 that will close this issue
@Brandhoej
Copy link
Contributor Author

Closed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant