Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Location types can cause confusion #72

Closed
Brandhoej opened this issue Sep 13, 2022 · 1 comment · Fixed by #74
Closed

Multiple Location types can cause confusion #72

Brandhoej opened this issue Sep 13, 2022 · 1 comment · Fixed by #74
Labels
enhancement New feature or request

Comments

@Brandhoej
Copy link
Contributor

Motivated by Issue #71 it might be desirable to have a single class of Location and use that to cover all types. This removes type confusion, removes explicit type conversion which can cause runtime errors, and it ultimately allows us to later be more better at handling memory allocation by using an Object pool.

In another experimental branch I have found a way to merge all Location classes into a single Location class. As of now, it requires some clean up, but might be a great starting point for discussion.

@Brandhoej Brandhoej added the enhancement New feature or request label Sep 13, 2022
@Brandhoej Brandhoej mentioned this issue Oct 2, 2022
@Brandhoej Brandhoej linked a pull request Oct 2, 2022 that will close this issue
@Brandhoej
Copy link
Contributor Author

Closed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant