New cdd functions #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging
…fixed a quotient bug
…robust and less stateless
…are now being used
Fix/quotient
|
How should we approach the review of this? It contains 175 commits, so a normal full review is infeasible. Maybe just merge this as-is, so we can continue our development? |
@magoorden yes I believe that would be the right choice. Given that all my commits in this branch has already been reviewed (Which is most of them). |
magoorden
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges all the work done on the branch "new-cdd-functions" into "main".
Description
A lot of work has been done on the branch "new-cdd-functions" which should be part of future releases of "main". This PR is a part of the work which aims towards a more structured development (Branch strategy) with shorter branch lifetimes and a specified approach for contribution and collaboration (Inspired by #75).