-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[BUG] Search page rolls back to initial state whenever a new search filter is added/removed. #9738
Comments
To reduce notifications, issues are locked until they are
🏁 status: ready for dev
|
Confirmed this bug is happening and I will unlock, however, I am not able to assign this issue to you as you have not explained your approach to solve this. Can you please add more detail on what you would like to do to address the issue? |
The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md |
I would like to work on this issue , can you assign this to me . I know I have another issue, but I solved it and sent a pull request , waiting for getting merge. ℹ️ pratik9818 has some opened assigned issues: 🔧View assigned issues |
Interested |
@pratik9818 your PR for your existing issue will need to be merged before we assign another issue to you. This ensures a fair approach and gives everyone an opportunity to contribute. In any event, as Amanda mentioned (@jatingodnani please also take note of this) - this issue cannot be assigned until whoever is looking to work on it explains their approach to resolving it. |
@SaraJaoude, I found the bug in the code. We are rendering two things: 'users' and 'visibleUsers.' 'Users' contains an array of updated users, while 'visibleUsers' contains an array of search results due to a query from the 'users' array. 'VisibleUsers' takes some time to render, so I added a loading indicator. We don't need to render updated users every time; we only show updated users if the input box is empty. |
Thank you for explaining the approach you would like to take. I will assign this to you to begin work on the proposed solution. |
Unassigning for this reason: #9788 (comment) |
I see this is no longer assigned. Noticed it does not have the
Extra:
|
@stefanzmf Assigning the issue to you |
Opened the PR. Please let me know if there are further steps that needs to be done from my side. Thank you ℹ️ stefanzmf has some opened assigned issues: 🔧View assigned issues |
Pull Request merged ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues |
Has this bug been raised before?
Where did you find this bug?
Production
Version of BioDrop (for example "v1.2.3")
v2.84.4
Description
On the search page, when multiple filters are selected whenever a new filter is added/removed the display data rolls back to the initial state for a moment and then displays the new data.
For example if I have selected react, then the result will be shown for react then if i also select python then for a few seconds i will see the initial unfiltered search result and then the result for react+python filter
Screenshots
No response
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
No response
The text was updated successfully, but these errors were encountered: