[bug]:corrected the search functionality #9788
Conversation
|
@eddiejaoude review my code |
|
Seems like the search tests are failing |
|
Why this is failing,in my local host it is working fine |
the automated tests pass for you locally? |
|
I have change some ui,which is working fine in my local |
can you please share the results of running the tests locally
you can see the failing tests in the GitHub Action |
|
@eddiejaoude help me to find why 5th case is failing |
|
@jatingodnani please resolve the merge conflicts |
|
It seems like the test checks are expected different results before as to now 1) [chromium] › search.spec.js:22:5 › Search works correctly ─────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveCount(expected)
Locator: locator('main li')
Expected: 1
Received: 0Please run the tests and check your changes. https://github.com/EddieHubCommunity/BioDrop/actions/runs/6913193428/job/18823909700?pr=9788 note: I don't think we need a loading state, when we upgrade to the latest nextjs, this will come in as part of that |
|
@jatingodnani were you able to resolve the conflicts? |
|
Yes,i solved this problem ,but i am not understand why my test case is failing |
| return () => { | ||
| clearTimeout(timer); | ||
| }; |
There was a problem hiding this comment.
Does the coding style need to be changed here?
| <div className="flex items-center justify-center mt-8 w-[97%]"> | ||
| <div | ||
| class=" animate-spin rounded-full border-opacity-25 h-10 w-10 border-4 | ||
| border-t-blue-500 " |
There was a problem hiding this comment.
| border-t-blue-500 " | |
| border-t-blue-500" |
| </ul> | ||
|
|
||
| {loading && ( | ||
| <div className="flex items-center justify-center mt-8 w-[97%]"> |
From the GitHub Action, you can see... |
|
Given the length of time that this PR has been open and maintainer comments have not been addressed, I will close this to give someone else in the community an opportunity to work on it. |
closes #9738
[*] My code follows the code style of this project.
[* ] My change requires changes to the documentation.
[ *] I have updated the documentation accordingly.
[* ] All new and existing tests passed.
[ *] This PR does not contain plagiarized content.
[ *] The title of my pull request is a short description of the requested changes.
Added loader indicator so that if any search, intially at the query time it shows the recently updated user but i have done some changes or added to the code so it showing loading indicatior, not the recently updated users.