Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

FIX : [BUG] No padding around 'Select a tab' label in mobile view #10150 #10191

Merged
merged 6 commits into from
Mar 22, 2024
Merged

FIX : [BUG] No padding around 'Select a tab' label in mobile view #10150 #10191

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49f2946
added padding to the select a tab label
eugene4545 Jan 28, 2024
cf1126b
added padding to the select a tab label
eugene4545 Jan 28, 2024
1c472b0
added padding to the select a tab label
eugene4545 Jan 28, 2024
1d4bb07
style: reorder utility classes for improved readability
eugene4545 Jan 31, 2024
eae96ec
Merge branch 'EddieHubCommunity:main' into eugene4545-styling-patch
eugene4545 Feb 1, 2024
3bd79d4
rearranged class names according to tailwind's recommended order
eugene4545 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/event/EventTabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function EventTabs({ tabs, eventType, onEventTypeChange }) {
label="Select a tab"
value={tabs.find((tab) => tab.key === eventType)?.title}
onChange={(e) => changeTab(e)}
className="block w-full rounded-md border-primary-medium-low dark:bg-primary-medium dark:focus:border-secondary-low dark:focus:ring-secondary-low focus:border-secondary-low focus:ring-secondary-low"
className="block w-full rounded-md border-primary-medium-low dark:bg-primary-medium dark:focus:border-secondary-low dark:focus:ring-secondary-low focus:border-secondary-low focus:ring-secondary-low px-3 py-1 mb-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Perhaps consider adding the classes before the dark: and focus: variants. Doesn't Prettier usually take care of that automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback, Arvind I've reordered the class names as suggested, with the dark and focus variants now at the end. As for Prettier, it doesn't seem to sort the class names automatically, so I manually rearranged them. Let me know if there's anything else I can do to improve the PR. Thanks again!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the Tailwind plugin for sorting
https://tailwindcss.com/blog/automatic-class-sorting-with-prettier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eugene4545!
Oh I didn't know about the extra plugin, thanks @ThomasCode92 👍🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ThomasCode92 , I have applied the tailwind prettier plugin on the code to rearrange the class name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arvind I was wondering if there are any remaining issues that need to be addressed.

Copy link
Member

@ArvindParekh ArvindParekh Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think the pr solves the mentioned issue. Let's wait for others to review it and get it merged :)

options={tabs.map((tab) => ({ label: tab.title, value: tab.title }))}
/>
</div>
Expand Down
Loading