This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix:multiple re-render in profile page #9380
Merged
eddiejaoude
merged 6 commits into
EddieHubCommunity:main
from
sital002:profile-page-rendering-issue
Oct 14, 2023
Merged
fix:multiple re-render in profile page #9380
eddiejaoude
merged 6 commits into
EddieHubCommunity:main
from
sital002:profile-page-rendering-issue
Oct 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
suggested changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a props for |
I think we need to update the test for the profile page since I used a button instead of a link in the |
dan-mba
reviewed
Oct 9, 2023
dan-mba
reviewed
Oct 9, 2023
eddiejaoude
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
closes #9368
Changes proposed
Refactor the UserTabs component and added
shallow:true
which will prevent re-runninggetServerSideProps
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers