Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix:multiple re-render in profile page #9380

Merged

Conversation

sital002
Copy link
Member

@sital002 sital002 commented Oct 6, 2023

Fixes Issue

closes #9368

Changes proposed

Refactor the UserTabs component and added shallow:true which will prevent re-running getServerSideProps

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Oct 6, 2023
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution Sital, but I get this error in your branch

Screenshot 2023-10-07 at 05 28 36

@sital002
Copy link
Member Author

sital002 commented Oct 7, 2023

I added a props for Tabs component but I forgot to add it in the manage/profile page. Let me fix that

@sital002 sital002 marked this pull request as draft October 7, 2023 05:15
@sital002
Copy link
Member Author

sital002 commented Oct 7, 2023

I think we need to update the test for the profile page since I used a button instead of a link in the Tabs component the test should be changed accordingly.

@sital002 sital002 requested a review from eddiejaoude October 7, 2023 06:16
@sital002 sital002 marked this pull request as ready for review October 7, 2023 06:17
components/navbar/SubNav.js Outdated Show resolved Hide resolved
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@eddiejaoude eddiejaoude merged commit 9ef1fbe into EddieHubCommunity:main Oct 14, 2023
@sital002 sital002 deleted the profile-page-rendering-issue branch October 14, 2023 05:25
@eddiejaoude eddiejaoude mentioned this pull request Oct 14, 2023
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] profile page is rendering twice
3 participants