[FEATURE] Improvement - char limit on tags #9762

pratik9818 · 2023-11-10T18:30:56Z

Fixes Issue

closes #9345

Changes proposed

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
My change requires changes to the documentation.
[ x] I have updated the documentation accordingly.
[ x] All new and existing tests passed.
[x ] This PR does not contain plagiarized content.
[ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

akash19coder · 2023-11-11T13:56:58Z

@pratik9818 I have noticed there are so many formatting issues in the files where you have made changes. Please format your code and push the formatted code🙂.

components/tag/TagsInput.js

accodes21

Looks good

pages/docs/how-to-guides/editing-forms.mdx

components/tag/TagsInput.js

pratik9818 · 2023-11-17T16:23:11Z

hi @SaraJaoude , I completely understand you're busy. I would be grateful if you could take some time to review the pull request because i love to work on another issue so it would be great if this will get merge.I look forward to hearing your thoughts on the changes if something needs to add or remove in code .

eddiejaoude · 2023-11-17T18:10:04Z

cls

+branch.main.remote=origin
+branch.main.merge=refs/heads/main
+branch.char.remote=origin
+branch.char.merge=refs/heads/char


I don't think this file is needed - please remove and add it to your gitignore

pages/docs/how-to-guides/editing-forms.mdx

pages/account/manage/profile.js

components/tag/TagsInput.js

eddiejaoude · 2023-11-17T18:24:07Z

components/tag/TagsInput.js

@@ -11,10 +18,22 @@ export default function TagsInput({ tags, onTagAdd, onTagRemove }) {
    backspace: 8,
  };

+  const maxTagChar = 32;


I think this can be renamed to maxLength because it is already in the tag component

eddiejaoude · 2023-11-17T18:24:38Z

components/tag/TagsInput.js

    if (e.keyCode === comma || inputValue.endsWith(",")) {
-      const newTag = inputValue.trim().replace(/,/g, "");
+      let newTag = inputValue.trim().replace(/,/g, "");


why is this changed required?

eddiejaoude

Looks good 👍 I have left inline comments

Also it breaks on the manage event page add/edit with tags

pratik9818 · 2023-11-17T19:08:21Z

@eddiejaoude , should i update the tag description in event page as well , like a profile page

eddiejaoude · 2023-11-17T19:14:32Z

eddiejaoude , should i update the tag description in event page as well , like a profile page

yes please make it consistent

Can you also resolve the conflicts please

eddiejaoude · 2023-11-17T19:31:23Z

Did you mean to close the PR?

No need to force push, commits will be squashed, plus this makes reviewing very difficult

pratik9818 · 2023-11-17T19:35:20Z

i did not do nothing, i don't know how it happend , what should i do now ?

eddiejaoude · 2023-11-17T19:38:14Z

You can see from the timeline in the issue above your comment that you closed and forced pushed to your branch

I am not sure, I never force push. Try to reopen the PR

pratik9818 · 2023-11-17T20:16:06Z

@eddiejaoude , i reopend the PR

eddiejaoude · 2023-11-17T20:19:48Z

Oh your force push undid my changes I made 😞 - I will look to make them again soon

pratik9818 · 2023-11-17T20:27:01Z

Apology @eddiejaoude , i will keep in mind next time . But i made the all changes you said to changed

eddiejaoude · 2023-11-17T20:50:55Z

Apology @eddiejaoude , i will keep in mind next time . But i made the all changes you said to changed

no problem, I made additional changes in addition to the comments

pratik9818 · 2023-11-18T08:40:29Z

hi @eddiejaoude what should i do now , i mean, is their any changes i have to do ?

components/tag/TagsInput.js

pages/account/manage/event/[[...data]].js

components/tag/TagsInput.js

eddiejaoude · 2023-11-19T10:27:58Z

pages/account/manage/profile.js

@@ -247,8 +247,7 @@ export default function Profile({ BASE_URL, profile, fileExists }) {
                        setShowNotification={setShowNotification}
                      />
                      <p className="text-sm text-primary-medium-low dark:text-primary-low-high">
-                        Separate tags with commas and Maximum 32 characters
-                        allowed in each tag.
+                        Separate tags with commas (max 32 characters).


why do my inline changes keep getting removed?

eddiejaoude

The additional changes seem to have moved the PR backwards and the package lock file has also been added, please remove

pratik9818 · 2023-11-19T17:46:37Z

i am working on those issues

eddiejaoude · 2023-11-19T18:02:41Z

Ok if you need any help let us know

pratik9818 · 2023-11-22T05:09:19Z

@eddiejaoude can i restart my char branch like updating char branch same as this project main branch because i think i am unable to update or back all those changes which u mentioned, or create new PR. can u help me out from this.

pratik9818 · 2023-11-23T02:25:46Z

Status - still fixing it.

pratik9818 · 2023-11-23T18:55:41Z

@eddiejaoude i fixed the issue and i had to hard push code for solveing that issue . kindly can you check ?
extremely sorry for your trouble .

components/tag/TagsInput.js

pages/account/manage/profile.js

eddiejaoude · 2023-11-23T19:02:03Z

i fixed the issue and i had to hard push code for solveing that issue . kindly can you check ? extremely sorry for your trouble .

Looks good, thank you for fixing, but force push is probably what is causing all the problems. I left a tiny inline comment

eddiejaoude

Thank you 👍

pratik9818 · 2023-11-28T07:32:55Z

Thank you 👍

Thank you @eddiejaoude for supporting

pratik9818 requested a review from SaraJaoude as a code owner November 10, 2023 18:30

github-actions bot added the 📖 docs Documentation pages label Nov 10, 2023

akash19coder reviewed Nov 11, 2023

View reviewed changes

components/tag/TagsInput.js Outdated Show resolved Hide resolved

accodes21 reviewed Nov 11, 2023

View reviewed changes

pages/docs/how-to-guides/editing-forms.mdx Outdated Show resolved Hide resolved

akash19coder reviewed Nov 11, 2023

View reviewed changes

components/tag/TagsInput.js Show resolved Hide resolved

eddiejaoude reviewed Nov 17, 2023

View reviewed changes

pages/docs/how-to-guides/editing-forms.mdx Outdated Show resolved Hide resolved

eddiejaoude reviewed Nov 17, 2023

View reviewed changes

pages/account/manage/profile.js Outdated Show resolved Hide resolved

eddiejaoude reviewed Nov 17, 2023

View reviewed changes

components/tag/TagsInput.js Show resolved Hide resolved

eddiejaoude reviewed Nov 17, 2023

View reviewed changes

eddiejaoude suggested changes Nov 17, 2023

View reviewed changes

pratik9818 closed this Nov 17, 2023

pratik9818 force-pushed the char branch from e14817d to f4d9d17 Compare November 17, 2023 19:24

github-actions bot added the issue linked Pull Request has issue linked label Nov 17, 2023

pratik9818 reopened this Nov 17, 2023

eddiejaoude reviewed Nov 18, 2023

View reviewed changes

components/tag/TagsInput.js Show resolved Hide resolved

eddiejaoude reviewed Nov 18, 2023

View reviewed changes

pages/account/manage/event/[[...data]].js Outdated Show resolved Hide resolved

eddiejaoude reviewed Nov 19, 2023

View reviewed changes

components/tag/TagsInput.js Show resolved Hide resolved

eddiejaoude reviewed Nov 19, 2023

View reviewed changes

eddiejaoude suggested changes Nov 19, 2023

View reviewed changes

pratik9818 closed this Nov 23, 2023

pratik9818 force-pushed the char branch from 8d814b7 to e3767d0 Compare November 23, 2023 16:03

pratik9818 reopened this Nov 23, 2023

pratik9818 closed this Nov 23, 2023

pratik9818 force-pushed the char branch from a2acb48 to e3767d0 Compare November 23, 2023 17:23

changing

87b73cb

pratik9818 reopened this Nov 23, 2023

github-actions bot removed the 📖 docs Documentation pages label Nov 23, 2023

update all changes

62cb8d3

github-actions bot added the 📖 docs Documentation pages label Nov 23, 2023

complete all changes

89e45f7

eddiejaoude reviewed Nov 23, 2023

View reviewed changes

components/tag/TagsInput.js Show resolved Hide resolved

eddiejaoude reviewed Nov 23, 2023

View reviewed changes

pages/account/manage/profile.js Outdated Show resolved Hide resolved

Update components/tag/TagsInput.js

fe99f2f

pratik9818 added 3 commits November 24, 2023 09:20

done

fb87a8e

Merge branch 'char' of https://github.com/pratik9818/BioDrop into char

a8b2279

done

141ca2c

eddiejaoude approved these changes Nov 28, 2023

View reviewed changes

eddiejaoude merged commit eac304e into EddieHubCommunity:main Nov 28, 2023
13 checks passed

pratik9818 deleted the char branch November 30, 2023 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] Improvement - char limit on tags #9762

[FEATURE] Improvement - char limit on tags #9762

pratik9818 commented Nov 10, 2023 •

edited by eddiejaoude

Loading

akash19coder commented Nov 11, 2023

accodes21 left a comment

pratik9818 commented Nov 17, 2023 •

edited

Loading

eddiejaoude Nov 17, 2023 •

edited

Loading

pratik9818 Nov 17, 2023

eddiejaoude Nov 17, 2023

pratik9818 Nov 17, 2023

eddiejaoude Nov 17, 2023

eddiejaoude left a comment

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023 •

edited

Loading

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 18, 2023

eddiejaoude Nov 19, 2023

eddiejaoude left a comment •

edited

Loading

pratik9818 commented Nov 19, 2023

eddiejaoude commented Nov 19, 2023

pratik9818 commented Nov 22, 2023 •

edited

Loading

pratik9818 commented Nov 23, 2023

pratik9818 commented Nov 23, 2023

eddiejaoude commented Nov 23, 2023

eddiejaoude left a comment

pratik9818 commented Nov 28, 2023

[FEATURE] Improvement - char limit on tags #9762

[FEATURE] Improvement - char limit on tags #9762

Conversation

pratik9818 commented Nov 10, 2023 • edited by eddiejaoude Loading

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

akash19coder commented Nov 11, 2023

accodes21 left a comment

Choose a reason for hiding this comment

pratik9818 commented Nov 17, 2023 • edited Loading

eddiejaoude Nov 17, 2023 • edited Loading

Choose a reason for hiding this comment

pratik9818 Nov 17, 2023

Choose a reason for hiding this comment

eddiejaoude Nov 17, 2023

Choose a reason for hiding this comment

pratik9818 Nov 17, 2023

Choose a reason for hiding this comment

eddiejaoude Nov 17, 2023

Choose a reason for hiding this comment

eddiejaoude left a comment

Choose a reason for hiding this comment

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 17, 2023 • edited Loading

eddiejaoude commented Nov 17, 2023

pratik9818 commented Nov 18, 2023

eddiejaoude Nov 19, 2023

Choose a reason for hiding this comment

eddiejaoude left a comment • edited Loading

Choose a reason for hiding this comment

pratik9818 commented Nov 19, 2023

eddiejaoude commented Nov 19, 2023

pratik9818 commented Nov 22, 2023 • edited Loading

pratik9818 commented Nov 23, 2023

pratik9818 commented Nov 23, 2023

eddiejaoude commented Nov 23, 2023

eddiejaoude left a comment

Choose a reason for hiding this comment

pratik9818 commented Nov 28, 2023

pratik9818 commented Nov 10, 2023 •

edited by eddiejaoude

Loading

pratik9818 commented Nov 17, 2023 •

edited

Loading

eddiejaoude Nov 17, 2023 •

edited

Loading

pratik9818 commented Nov 17, 2023 •

edited

Loading

eddiejaoude left a comment •

edited

Loading

pratik9818 commented Nov 22, 2023 •

edited

Loading