Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat: get top 20 popular icons from backend #9819

Merged

Conversation

bikrantjajware
Copy link
Contributor

Fixes Issue

Closes issue #9230

Changes proposed

  • add api to get top 20 popular icons from mongo

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • [] My change requires changes to the documentation.
  • [] I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

@sital002 sital002 linked an issue Nov 23, 2023 that may be closed by this pull request
@sital002 sital002 added the issue linked Pull Request has issue linked label Nov 23, 2023
},
},
{
$sort:{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the formatting of this code is not inline with the project, check you have Prettier VScode plugin installed, it will fix this on save

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you 👍

I will fix the code formatting in a temporary PR

@eddiejaoude eddiejaoude changed the base branch from main to fix-pr-9819 November 27, 2023 15:17
@eddiejaoude eddiejaoude merged commit cd0ae3b into EddieHubCommunity:fix-pr-9819 Nov 27, 2023
13 checks passed
eddiejaoude added a commit that referenced this pull request Nov 27, 2023
* feat: get top 20 popular icons from db (#9819)

* feat: popular icons counter badgge

* Update pages/api/icons.js

* Update pages/api/icons.js

---------

Co-authored-by: Bikrant Jajware <[email protected]>
@bikrantjajware
Copy link
Contributor Author

Thanks Eddie, i was on new laptop might have missed the extension

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Icon search page list popular icons dynamically
3 participants