Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

No Space between add link and first link #9406 Fixed #9841

Closed
wants to merge 15 commits into from

Conversation

ScriptShah
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • [] My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

before and after the changes

img1

changes check with all pages that uses the layout and encounter with no issue.

img3

Note to reviewers

please accept my pr if it was fair.

@eddiejaoude
Copy link
Member

Original PR #9822

@sital002 sital002 linked an issue Nov 27, 2023 that may be closed by this pull request
@sital002 sital002 added the issue linked Pull Request has issue linked label Nov 27, 2023
@ScriptShah
Copy link
Contributor Author

Has my pr been accepted?

@eddiejaoude
Copy link
Member

The component Page is used in 44 files, these will all need to be tested

@ScriptShah
Copy link
Contributor Author

eddiejaoude

The component Page is used in 44 files, these will all need to be tested

should i test it or someone else does ?

@eddiejaoude
Copy link
Member

eddiejaoude

The component Page is used in 44 files, these will all need to be tested

should i test it or someone else does ?

You need to test your own changes, otherwise how do you know they work correctly and don't have a negative effect on the project?

@ScriptShah
Copy link
Contributor Author

ScriptShah commented Dec 9, 2023

I test all 44 files , it does not have any negative effect on the project.

@eddiejaoude
Copy link
Member

I have tested it and it makes the spacing on every page bigger

BEFORE: profile page

Screenshot 2023-12-18 at 07 00 43

AFTER: profile page

Screenshot 2023-12-18 at 07 00 48

BEFORE: search

Screenshot 2023-12-18 at 07 01 25

AFTER: search

Screenshot 2023-12-18 at 07 01 30

I will close as this is going off topic

@eddiejaoude
Copy link
Member

#9406

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No Space between add link and first link
3 participants