This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
feat: group suggestions for users link #9878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
reviewed
Dec 7, 2023
Co-authored-by: Eddie Jaoude <[email protected]>
eddiejaoude
suggested changes
Dec 7, 2023
badrivlog
reviewed
Dec 15, 2023
components/GroupLinkSearch.js
Outdated
Comment on lines
27
to
32
| <Label htmlFor="search-groups">Group</Label> | ||
| <Combobox.Input | ||
| name="search-group" | ||
| onChange={handleGroupChange} | ||
| className={`border-2 transition-all duration-250 ease-linear rounded px-6 py-2 mb-2 block w-full dark:bg-primary-high hover:border-tertiary-medium focus:ring-0 focus:border-tertiary-medium focus:outline-0`} | ||
| /> |
There was a problem hiding this comment.
It would be better if we associated the label with the input field explicitly by using id attribute. This enhances accessibility by establishing a clear connection between label and input.
The following resources could be helpful: https://www.w3.org/WAI/tutorials/forms/labels/#associating-labels-explicitly
There was a problem hiding this comment.
If this still needs improving, could you raise as a separate issue, thank you 👍
There was a problem hiding this comment.
Sure, I'll create a new issue to address the improvement. Thanks for your guidance! 👍
badrivlog
reviewed
Dec 15, 2023
sital002
changed the title
…m/sital002/BioDrop into feat-groups-suggestions-for-links
This was referenced Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
closes #9836
Changes proposed
Users will be able to view all the previous groups.
Check List (Check all the applicable boxes)
Screenshots
After changes:
Note to reviewers