Added support for Cordova Android 7 (patch) #65
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cordova Android 7.0.0 changed the file structure which breaks this plugin. This PR fixes that. https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html
|
Hi, thanks! is this change backward compatible with version < 7? |
|
Unfortunately, I don't believe it is. I guess that would cause problems since not everyone is on 7. I've actually had to downgrade back to 6 due to lack of support for 7, though. I'm not sure what the best way to handle this would be. |
|
Could you try having both the old and new approach in config.xml? So add the new line of code, and leave the current one intact. Perhaps Cordova accepts this.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cordova Android 7.0.0 changed the file structure which breaks this plugin. This PR fixes that.
https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html