-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Push Publisher #27
base: develop
Are you sure you want to change the base?
Conversation
GoodluckH
commented
Jul 15, 2022
•
edited
Loading
edited
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1202587387735569
6bb1692
to
5715a0c
Compare
9f6ec41
to
6bb1692
Compare
/rebase-autosquash |
6bb1692
to
97e8c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we agreed that the ActionEffect type is going to be:
{
type,
completed,
program
}
Instead of spreading all the props no?
During the call, I thought we are going to use Sam's front-end implementation of ActionEffects? He also sent the code snippet for the type here: https://edgesecure.slack.com/archives/C03PG9LVDM3/p1657832756200729 |
I have switched this branch from |
src/types/task/ActionEffect.ts
Outdated
export interface SeqActionEffect extends GeneralActionEffect { | ||
type: 'seq' | ||
opIndex: number | ||
childEffect: ActionEffect | ||
} | ||
|
||
export interface ParActionEffect extends GeneralActionEffect { | ||
type: 'par' | ||
childEffects: ActionEffect[] | ||
} | ||
|
||
export interface BalanceActionEffect extends GeneralActionEffect { | ||
type: 'balance' | ||
address: string | ||
aboveAmount?: string | ||
belowAmount?: string | ||
walletId: string | ||
tokenId?: string | ||
} | ||
|
||
export interface TxConfsActionEffect extends GeneralActionEffect { | ||
type: 'tx-confs' | ||
txId: string | ||
walletId: string | ||
confirmations: number | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are client-side types, not server types. I talked to Sam about this, and we agreed that the client needs to "bake" these down a bit more before sending them to the server.
For instance, walletId
is useless to the server, since the server cannot access customer wallets. Instead, the client needs to extract a single network address for the server to check. Likewise, par
and seq
are something the client worries about as it executes the program. Once the client figures out what the next steps are, it uploads them to the server, so the server doesn't need to know how they are linked.
Nevertheless, I think we can go ahead and merge this now and fix it later - I don't want to slow down the project, and something is better than nothing.
0822833
to
5d964f5
Compare