-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.9 : Linux CPN AppImage SSL packaging #4533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined update and install was failing due to kitware repo error during update
Win32, Win64 and Linux targets functional for update/downloading (SSL), DFU updates (Linux may require host level dfu-util), and read/write of models. MacOS build only had superficial changes and |
This was
linked to
issues
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug/regression ↩️
A new version of EdgeTX broke something
companion
Related to the companion software
compilation
Related to compiling the firmware and firmware options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4424, fixes #4316
Summary of changes:
edit: Looking at the output file, looks like more is needed. hm... this is still showing...> -- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR)some time later:
Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.1.1")
🥳 🚀Known limitation:
dfu-util
is now correctly packaged, and with the correct permissions. Companion currently does not use it, and instead is hard-coded to use the system/usr/bin/dfu-util
rather than the packageddfu-util
. However there is little point resolving this at present, as it appears from testing thatdfu-util
cannot actually access a radio ifdfu-util
is not installed on the host OS. Thus the message thatdfu-util
is missing should prompt the user to install it if they want to use DFU with Companion. If this is something we can resolve in the future then the packaged version should naturally be changed.