Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9 : Linux CPN AppImage SSL packaging #4533

Merged
merged 14 commits into from
Jan 14, 2024
Merged

2.9 : Linux CPN AppImage SSL packaging #4533

merged 14 commits into from
Jan 14, 2024

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Jan 12, 2024

Fixes #4424, fixes #4316

Summary of changes:

edit: Looking at the output file, looks like more is needed. hm... this is still showing...
> -- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR)

some time later:

  • Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.1.1") 🥳 🚀

Known limitation: dfu-util is now correctly packaged, and with the correct permissions. Companion currently does not use it, and instead is hard-coded to use the system /usr/bin/dfu-util rather than the packaged dfu-util. However there is little point resolving this at present, as it appears from testing that dfu-util cannot actually access a radio if dfu-util is not installed on the host OS. Thus the message that dfu-util is missing should prompt the user to install it if they want to use DFU with Companion. If this is something we can resolve in the future then the packaged version should naturally be changed.

@pfeerick pfeerick added this to the 2.9.3 milestone Jan 12, 2024
@pfeerick pfeerick added companion Related to the companion software compilation Related to compiling the firmware and firmware options bug/regression ↩️ A new version of EdgeTX broke something labels Jan 12, 2024
@pfeerick pfeerick changed the title 2.9_cpn_ssl_packaging 2.9 : Linux CPN AppImage SSL packaging Jan 12, 2024
@pfeerick
Copy link
Member Author

Win32, Win64 and Linux targets functional for update/downloading (SSL), DFU updates (Linux may require host level dfu-util), and read/write of models. MacOS build only had superficial changes and dfu-util is still present in the bundle.

@pfeerick pfeerick merged commit a468fcd into 2.9 Jan 14, 2024
38 checks passed
@pfeerick pfeerick deleted the 2.9_cpn_ssl_packaging branch January 14, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software compilation Related to compiling the firmware and firmware options
Projects
None yet
1 participant