-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sim): key labels match physical radios #5865
Conversation
V16, TX12Mk2, GX12 and I suppose all Radiomaster radios having two separate buttons for up and down have those buttons labelled "Page>" and "Page<". All single button radios I know use "</>" apart from Taranis like X9D+ and +2019 use "page". |
Jumper radios like the bumblebee use '</>' as the page key label. This is the list I was working on - have not checked them all, and I will be away for a few days.
|
Thanks @philmoz |
53a44f9
to
dcc33b5
Compare
dcc33b5
to
71e4ffd
Compare
This will partially break the simulator key mapping help. To avoid holding up this PR with 2.11 getting close, a separate PR will be created to fix the help as it is a lower priority and there maybe some compromises depending on what this PR unearths. |
Is there anything left to do for this PR... for now? |
The code change appears to fix the issue. The matrix is still a wip however we could merge this one and create another to finish. |
Ok, I'll see if any other handset key names jump out at me tomorrow morning and then merge.... There are about 6 targets left... tlite, lr3pro, commando8 and the x9 / xlite radios... the lr3pro/commando8 are near enough IMO as they don't actually have any real legends for the keys... x9/xlite I don't know about at all. I just realised after merging the the TLite does have a legend for the keys... (under the sleeve I have mine in 🤦) so it wants ENT/RTN also. |
Co-authored-by: philmoz <[email protected]> Co-authored-by: Peter Feerick <[email protected]>
Fixes #5860
Summary of changes:
TODO: