fix: don't check ELRS version if crossfire disabled #5961
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `-DCROSSFIRE=N` defined at compile time, calls to `CRSF_ELRS_MIN_VER()` are not valid. Also, use the helper function rather than reinvent the wheel
pfeerick
added
bug/regression ↩️
|
What say you @mha1 ? 🤭 |
Me says well done, nice and tidy. The macro was implemented months after the change for ELRS binding via ETX UI. Missed using the macro there also. Good find. Clearly the ifdef was missing but as Crossfire is a default yes the check builds didn't catch it. Good find too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5960
Summary of changes:
-DCROSSFIRE=Ndefined at compile time, calls toCRSF_ELRS_MIN_VER()are not valid, and response should simply be "no".crossfireModuleStatusdoes not exist, so should not be checked.