Bug fix: change interruptible order in platform shutdown flow (#4539)

Effect-TS · Mar 3, 2025 · 99fcbf7 · 99fcbf7
1 parent 0d01480
commit 99fcbf7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/popular-ducks-guess.md b/.changeset/popular-ducks-guess.md
@@ -0,0 +1,6 @@
+---
+"@effect/platform-node": patch
+"@effect/platform-bun": patch
+---
+
+Fixed interruption of timeout in worker shutdown
diff --git a/packages/platform-bun/src/internal/worker.ts b/packages/platform-bun/src/internal/worker.ts
@@ -19,8 +19,8 @@ const platformWorkerImpl = Worker.makePlatform<globalThis.Worker>()({
             worker.postMessage([1])
             return Deferred.await(closeDeferred)
           }).pipe(
-            Effect.interruptible,
             Effect.timeout(5000),
+            Effect.interruptible,
             Effect.catchAllCause(() => Effect.sync(() => worker.terminate()))
           )
         ),

diff --git a/packages/platform-node/src/internal/worker.ts b/packages/platform-node/src/internal/worker.ts
@@ -20,8 +20,8 @@ const platformWorkerImpl = Worker.makePlatform<WorkerThreads.Worker>()({
             worker.postMessage([1])
             return Deferred.await(exitDeferred)
           }).pipe(
-            Effect.interruptible,
             Effect.timeout(5000),
+            Effect.interruptible,
             Effect.catchAllCause(() => Effect.sync(() => worker.terminate()))
           )
         ),