Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update vitest to v3 #4376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FedericoBiccheddu
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Update vitest to latest available major version, 3.0.

Related

@FedericoBiccheddu
Copy link
Contributor Author

FedericoBiccheddu commented Jan 31, 2025

Open as draft as some test are failing, one of them (test/CommandExecutor.test.ts) fails even on main and need to understand why.

@FedericoBiccheddu FedericoBiccheddu force-pushed the federico/update-to-vitest-3 branch from 46b2cc1 to 4e1dd73 Compare January 31, 2025 18:26
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: f61cfb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/vitest Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FedericoBiccheddu FedericoBiccheddu force-pushed the federico/update-to-vitest-3 branch from 55554c9 to 47b5601 Compare January 31, 2025 20:52
@FedericoBiccheddu
Copy link
Contributor Author

FedericoBiccheddu commented Jan 31, 2025

Open as draft as some test are failing, one of them (test/CommandExecutor.test.ts) fails even on main and need to understand why.

The problem was trivial: I don't have bash installed; trying with sh made the test pass!

@FedericoBiccheddu FedericoBiccheddu marked this pull request as ready for review January 31, 2025 21:04
@FedericoBiccheddu FedericoBiccheddu force-pushed the federico/update-to-vitest-3 branch 2 times, most recently from 7638323 to 8537c55 Compare February 3, 2025 15:03
@mikearnaldi
Copy link
Member

wondering if this should be a major given the 3.x bump on vitest

@FedericoBiccheddu
Copy link
Contributor Author

wondering if this should be a major given the 3.x bump on vitest

I initially thought a minor bump was ok for two reasons:

  • AFAIK @effect/vitest is not stable; other packages, like platform, rpc, etc have undergone massive refactors that resulted in BC, which were expected. Unless the approach has changed or I'm missing important information about the effect team's stance on BC, I'm personally fine w/ this being a minor bump instead of a v1.*, as it aligns with the principles of other effect packages from a consumer PoV;
  • the consumer API has not changed.

However, upon further reflection, @effect/vitest has a peer dep on vitest and users may have tests running on 2.x version without relying on @effect/test; this minor bump could be a BC for them hindering upgrades to other effect packages, right?

@codingismy11to7
Copy link

However, upon further reflection, @effect/vitest has a peer dep on vitest and users may have tests running on 2.x version without relying on @effect/test; this minor bump could be a BC for them hindering upgrades to other effect packages, right?

i thought about that too, but when i looked at the vitest 3.0 release notes it didn't look like a particularly onerous upgrade?

also, people who are depending on < 1.0 stuff (like myself) kinda need to be prepared for things like that, imo

@FedericoBiccheddu FedericoBiccheddu force-pushed the federico/update-to-vitest-3 branch from 8537c55 to e33c1d7 Compare February 4, 2025 11:56
@FedericoBiccheddu FedericoBiccheddu force-pushed the federico/update-to-vitest-3 branch from e33c1d7 to f61cfb6 Compare February 4, 2025 13:39
@IMax153
Copy link
Member

IMax153 commented Feb 4, 2025

i thought about that too, but when i looked at the vitest 3.0 release notes it didn't look like a particularly onerous upgrade?

It doesn't matter if the upgrade is "onerous" or not - if there are breaking changes in Vitest 3.0 that will affect the external API or functionality of @effect/vitest, a minor version bump of @effect/vitest (which allows for breaking changes before there is a major) or a major version bump is most appropriate.

I don't have a strong preference and am fine with just a minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

4 participants