-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update vitest to v3
#4376
base: main
Are you sure you want to change the base?
deps: update vitest to v3
#4376
Conversation
Open as draft as some test are failing, one of them ( |
46b2cc1
to
4e1dd73
Compare
🦋 Changeset detectedLatest commit: f61cfb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
55554c9
to
47b5601
Compare
The problem was trivial: I don't have |
7638323
to
8537c55
Compare
wondering if this should be a |
I initially thought a minor bump was ok for two reasons:
However, upon further reflection, |
i thought about that too, but when i looked at the vitest 3.0 release notes it didn't look like a particularly onerous upgrade? also, people who are depending on < 1.0 stuff (like myself) kinda need to be prepared for things like that, imo |
8537c55
to
e33c1d7
Compare
e33c1d7
to
f61cfb6
Compare
It doesn't matter if the upgrade is "onerous" or not - if there are breaking changes in Vitest 3.0 that will affect the external API or functionality of I don't have a strong preference and am fine with just a minor. |
Type
Description
Update
vitest
to latest available major version,3.0
.Related