-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Record.findFirstEntry #4500
base: next-minor
Are you sure you want to change the base?
feat: add Record.findFirstEntry #4500
Conversation
🦋 Changeset detectedLatest commit: 7b9d284 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2da00b1
to
ca71668
Compare
.type.toBe<Option.Option<[string, string | number]>>() | ||
expect(pipe(string$numbersOrStrings, Record.findFirstEntry((a, _) => predicateNumbersOrStrings(a)))) | ||
.type.toBe<Option.Option<[string, string | number]>>() | ||
expect(Record.findFirstEntry(string$numbersOrStrings, (a, _) => Predicate.isString(a))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This expect fails with Typescript 5.4.5. If you have any tip on how to fix it, I'm all ears!
495b3b2
to
5d68000
Compare
ca71668
to
5e004a4
Compare
fa33360
to
044cb83
Compare
5e004a4
to
35c8aa4
Compare
e21867a
to
629c0cf
Compare
35c8aa4
to
be08a08
Compare
e2610c7
to
0f2ebba
Compare
be08a08
to
d77362c
Compare
d77362c
to
7b9d284
Compare
e3284ed
to
d8b4da5
Compare
Type
Description
Adds
Record.FindFirstEntry
I could also add
Record.FindFirst
andRecord.FindFirstKey
if this gets accepted as it would a simpleOption.map
onfindFirstEntry
Related