Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eslint-plugin-deprecation #59

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

IMax153
Copy link
Member

@IMax153 IMax153 commented Nov 13, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

eslint-plugin-deprecation is now in maintenance mode and its functionality has been moved to an equivalent typescript-eslint rule. Enabling this plugin in v9 of ESLint throws an error because the plugin requires type information to work properly.

Furthermore, it seems as though eslint-plugin-deprecation always required type information to work properly, but we never had type information enabled and it seems like it wasn't being enforced by ESLint prior to v9.

Given we do NOT want to enable type information for ESLint, I am removing the rule from our templates.

Related

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: ff528fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IMax153 IMax153 merged commit 327cd88 into main Nov 13, 2024
12 checks passed
@IMax153 IMax153 deleted the chore/remove-eslint-plugin-deprecation branch November 13, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version for peerDependency
1 participant