Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fix: expose JsonSchema7Top and JsonSchema7 dts #623

Merged

Conversation

sukovanej
Copy link
Contributor

@sukovanej sukovanej commented Dec 4, 2023

I started seeing Cannot find name 'JsonSchema7Top'.

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 088d03e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gcanti
Copy link
Contributor

gcanti commented Dec 4, 2023

@sukovanej I think we can export them officially, just in case anyone wants to define something like decodeAST here

const decodeAST = (

p.s.
btw, any idea on a better name than JsonSchema7Top?

@sukovanej
Copy link
Contributor Author

@sukovanej I think we can export them officially, just in case anyone wants to define something like decodeAST here

const decodeAST = (

p.s. btw, any idea on a better name than JsonSchema7Top?

Nice, alright, I'll do it in this MR. Do you mean to export and generate docs also for all the JsonSchema7Any, JsonSchema7Unknown, ... parts of the JsonSchema7?

Regarding the JsonSchema7Top - I noticed some JSON Schema documents are talking about a root schema so maybe we could call it a JsonSchema7Root but I'm not sure this is actually the established term.

@gcanti
Copy link
Contributor

gcanti commented Dec 4, 2023

Do you mean to export and generate docs also for all the JsonSchema7Any, JsonSchema7Unknown, ... parts of the JsonSchema7?

yeah, so it will clarify the subset of JSON schema that we support

Regarding the JsonSchema7Top - I noticed some JSON Schema documents are talking about a root schema so maybe we could call it a JsonSchema7Root but I'm not sure this is actually the established term.

ok, I'll do it in the next minor release, thanks

@sukovanej sukovanej force-pushed the fix/remove-json-schema7-top-internal branch from fcac7e5 to e83ef64 Compare December 4, 2023 17:15
@sukovanej sukovanej force-pushed the fix/remove-json-schema7-top-internal branch from e83ef64 to 088d03e Compare December 4, 2023 17:16
@gcanti gcanti merged commit 3a56b06 into Effect-TS:main Dec 4, 2023
@gcanti
Copy link
Contributor

gcanti commented Dec 4, 2023

Thanks @sukovanej

@github-actions github-actions bot mentioned this pull request Dec 4, 2023
@sukovanej sukovanej deleted the fix/remove-json-schema7-top-internal branch December 4, 2023 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants