Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated simulation in Humble to Gazebo Harmonic #73

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

JesusSilvaUtrera
Copy link
Collaborator

@JesusSilvaUtrera JesusSilvaUtrera commented Aug 12, 2024

🎉 New feature

Closes #72

Summary

The simulation on Humble has been changed and now uses Gazebo Harmonic instead of Gazebo Fortress.

NOTE: I didn't include the gz-sim8 package on the package.xml because the rosdep keys for that package couldn't be found.

Test it

Just compile the workspace and run the simulation as always. Check that it uses Gazebo Harmonic and that the LiDAR works well.

Here you can see a video of the simulation:

Screencast-from-12-08-24-130404.1.mp4

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left some comments, I will try it locally.

@francocipollone
Copy link
Collaborator

Tried it locally and works great! Thanks!

Signed-off-by: JesusSilvaUtrera <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Copy link
Collaborator

image

I just pushed some changes to fix GUI config.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit 41ced19 into humble Aug 13, 2024
2 checks passed
@francocipollone francocipollone deleted the jsilva/migrate_humble_to_harmonic branch August 13, 2024 13:29
@francocipollone
Copy link
Collaborator

I will revert this PR in humble, however it will be applied to jazzy branch.

@francocipollone
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lidar isn't working correctly in Gazebo Fortress
2 participants