Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes a typo that happens to be a wrong command in the README
Summary
It happens that the 2nd command the readme shows is
ros2 launch andino_gz andino_gz.launch.py ros_bridge:=false rviz:=false
Note how both arguments are in lower case. That's not an issue for the
ros_bridge
argument but it is forrviz
see the screenshot below.I didn't dig too deep but it seems when doing the list comprehension to call
PythonExpression
it expectsFalse
(as a valid python boolean) instead offalse
which is happening here and thereIn the other hand
ros_bridge
is only used withIfCondition
, here.Nevertheless to maintain consistency and avoid having to set one argument in lower case and the other in upper case I changed both since
IfCondition
works both ways.I can keep the changes only up to
rviz
arg if you prefer it.