Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong command #77

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

Santti4go
Copy link
Member

🦟 Bug fix

Fixes a typo that happens to be a wrong command in the README

Summary

It happens that the 2nd command the readme shows is
ros2 launch andino_gz andino_gz.launch.py ros_bridge:=false rviz:=false
Note how both arguments are in lower case. That's not an issue for the ros_bridge argument but it is for rviz see the screenshot below.

image

I didn't dig too deep but it seems when doing the list comprehension to call PythonExpression it expects False (as a valid python boolean) instead of false which is happening here and there

In the other hand ros_bridge is only used with IfCondition, here.
Nevertheless to maintain consistency and avoid having to set one argument in lower case and the other in upper case I changed both since IfCondition works both ways.

I can keep the changes only up to rviz arg if you prefer it.

  • Updated documentation (as needed)

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone
Copy link
Collaborator

francocipollone commented Aug 21, 2024

Signed-off-by: Santti4go <[email protected]>
@Santti4go
Copy link
Member Author

@francocipollone francocipollone merged commit 8b2143a into Ekumen-OS:humble Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants