Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration to jazzy navigation #93

Open
wants to merge 12 commits into
base: jazzy
Choose a base branch
from

Conversation

daniel-lopez-puig
Copy link

@daniel-lopez-puig daniel-lopez-puig commented Feb 2, 2025

🦟 Bug fix

Fixes #85

Now passing nav2:=True argument (enable navigation) works on jazzy.
Changes migrating from humble to jazy:

  • Classes are all now accessed using :: and not / anymore
  • bt_navigator/plugin_lib_names now is ONLY used for custom pluguins, so we need to delete default ones already included
  • docking_server configuration (params) where missing (copy pasted from nav2 repo)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 Improvements

Summary

  • From container now you can access to ws/src so you can modify from host other packages adn access from container
  • Added colours and extra information on the terminal when executing ros packages to improve UX, specially usefull when debugging
  • Undo a hotfix for docker conatiner commit: 073dc67 that actually didn't work. Reverting it make it work again.
  • Added populated_office map
  • Renamed dockerfile to Dockerfile as build.sh was noted like this (and is the standard one)

JesusSilvaUtrera and others added 11 commits February 2, 2025 23:48
* First changes for the migration. still needs to be tested

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Simulation is now working with Jazzy

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Updated the version of the setup-ros step for testing

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Slam is working now

Signed-off-by: JesusSilvaUtrera <[email protected]>

---------

Signed-off-by: JesusSilvaUtrera <[email protected]>
Signed-off-by: Daniel López <[email protected]>
Signed-off-by: Daniel López <[email protected]>
Signed-off-by: Daniel López <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: Daniel López <[email protected]>
that actually didn't fix permissions and insted added error

Signed-off-by: Daniel López <[email protected]>
Signed-off-by: Daniel López <[email protected]>
Signed-off-by: Daniel López <[email protected]>
…stom ones, Default ones are all included. Also adding missing docking_server param config

Signed-off-by: Daniel López <[email protected]>
@daniel-lopez-puig daniel-lopez-puig changed the title Jazzy Fix migration to jazzy navigation Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants