-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sendonion: add total amount #8015
base: master
Are you sure you want to change the base?
Conversation
7be5a67
to
7593735
Compare
The parameter is accepted, but, unless I'm missing something, I think |
7593735
to
8e542ca
Compare
@endothermicdev, I've added a test. |
8e542ca
to
a2fd84b
Compare
Rebased and fixed conflicts. |
@endothermicdev, help. |
Ah, just need to run |
839e0ef
to
dbcb0cb
Compare
I suspect this will break pay, which uses sendonion only, and relies on the 0 total_msat? |
As this seems to be causing some downstream issues, but nothing is currently depending on it, I'm going to defer to 25.05 at this point. |
I will check. |
Changelog-Added: sendonion: a new paramter total_amount_msat to make MPP payments with sendpay and sendonion compatible. Signed-off-by: Lagrang3 <[email protected]>
57a534b
to
436b370
Compare
I fixed the backwards compatibility with pay and rebased. |
@endothermicdev |
Trying to use
sendonion
inrenepay
instead ofsendpay
I noticed that these two rpc's are not compatiblewith each other in multi-part payments, ie. if I send a partial payment with
sendpay
and try to completethe payment by sending another part with
sendonion
I get an error because in the internal walletsendpay
sets thetotal_amount
as specified by the user whilesendonion
does not making this amount to 0.Lightningd will only accept further payment parts if the total amounts match. With
sendonion
thereisn't a field to pass the total amount so we cannot proceed.
With this PR I have added a parameter to
sendonion
calledtotal_amount_msat
in order to make thesendpay
andsendonion
interfaces compatible.