xpay blinded path fix #8121
Open
xpay blinded path fix #8121
+85
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old blindedpay fields would have an entry per hop, but that was changed to a single per-path entry. The devtools hadn't caught up. Similarly, it didn't like descriptionless offer fields in invreqs and invoices. Signed-off-by: Rusty Russell <[email protected]>
Use larger CLTVs and we see the failure from l3, complaining the CLTV is outside the amount in the payment_constraint field, like: ``` Failing HTLC because of an invalid payload (TLV 10 pos 104): cltv_expiry 609 > payment_constraint 376 ``` Signed-off-by: Rusty Russell <[email protected]>
We added twice, which caused spurious failures in real-world cases. Signed-off-by: Rusty Russell <[email protected]> Reported-by: https://github.com/hMsats Fixes: ElementsProject#8119 Changelog-Fixed: `xpay` would double the CLTV values in blinded paths, sometimes causing spurious failures.
rustyrussell
force-pushed
the
guilt/xpay-blinded-path-fix
branch
from
fadd3f1 to
54cb309
Compare
Comment on lines
+809
to
+810
| # CLTV is blockheight (108) + 1 + 100 + 200 + 400 | ||
| l1.daemon.wait_for_log(f'Adding outgoing HTLC 0 amount=15002msat cltv={108 + 1 + 100 + 200 + 400}') |
There was a problem hiding this comment.
Strange this does not too?
# This works.
l1.rpc.pay(inv)
# CLTV is blockheight (108) + 1 + 100 + 200 + 400
> l1.daemon.wait_for_log(f'Adding outgoing HTLC 0 amount=15002msat cltv={108 + 1 + 100 + 200 + 400}')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8119