Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixes for rust stable clippy, and rust 1.56.1 compilation #221

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

delta1
Copy link
Member

@delta1 delta1 commented Feb 12, 2025

Fixes clippy for the stable CI job, and pins libc to 0.2.163 for the rust 1.56.1 job

Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 01b0d2c

@apoelstra
Copy link
Member

Thanks for your patience -- I am struggling to get my local CI to work with this crate but I think I've almost got it. The issue is that our integration tests require Elements 0.21, which requires building with a very old version of gcc and boost, whose glibc is no longer compatible with the one included in nixos-unstable.

So when I went to build this crate with a new nixpkgs, and run the integration tests that used elementsd compiled with the old one, it wouldn't run (got some runtime missing symbol errors related to glibc 2_38 or something).

The fix was to bump my version gcc up to 13 (maaybe it's possible to just update glibc but use an old gcc, but I doubt it and I didn't try). To do this I had to use the new gcc13 patches in roconnor-blockstream/elements-nix#4

Anyway, as a followup to this we should fix our integration tests to work with Elements 23, which builds with much newer tools (and should be more futureproof).

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 01b0d2c; successfully ran local tests; thanks!

@apoelstra apoelstra merged commit 0ea307a into ElementsProject:master Feb 14, 2025
5 checks passed
@delta1 delta1 deleted the ci-fixes branch February 15, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants