-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker installation steps #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all: great job and thank you very much for taking your time to make this. This is really great.
It's the first time ever I make this kind of review so hope my comments are understandable and ok with you. Let me know what you think.
docker/README.md
Outdated
|
||
1. build the tradenote image with your custom parameters | ||
``` | ||
docker build . -t tradenote --build-arg PARSE_INIT=APPLICATION_ID --build-arg PARSE_URL=http://pi:1337/parse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to replace http://pi:1337/parse with PARSE_SERVER_URL/parse to make it more generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, your way is better
docker/README.md
Outdated
docker-compose up -d | ||
``` | ||
|
||
3. modify PARSE_INIT, PARSE_MASTER_KEY, PARSEHOST in addclass.sh to match your environment, run addclass.sh to add classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also created a modifyuser.sh. Is it working ? If so, would be good to add it here. If not, maybe remove the modifyuser.sh file so that it's less confusing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "modifyuser.sh" only works for database ( I mean it can add data to mongodb, but not show in the dashboard, I cannt login to tradenote ), so users need step 6 to add columns and data to _User class
why I still pr this file, I am thinking maybe you or someone can find out a solution for this, so I can merge 2 scripts :)
if this is confusing, I will remove this script
docker/README.md
Outdated
|
||
4. register user via http://server:7777/register | ||
|
||
5. modify parameters to match your environment in localdashboard.yaml, run a standalone parse-dashboard container on local computer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally run and use the dashboard (quite regularly). So in my opinion, I would not just make it a "local" dashboard. So
1- I would add the parse-dashboard to the docker-composer
2- Make step 8 optional
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my thought is users like me dont need the dashboard, only the developer like you need it
why I made the "local" dashboard, because the modifyuser.sh is not working, users need this to add columns and data to _User class, once users added data, they can delete the local dashboard
another reason is parse-dashboard doesn't work on arm cpu, I cant make the whole tradenote services work on raspberry pi if add dashboard to the default docker-compose
but I am not sure, are users really dont need the dashboard? please let me know. this is my first time using parse:)
docker/README.md
Outdated
|
||
6. login to parse dashboard, add the following columns and data to "_User" | ||
``` | ||
user - type Pointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "(point to _User)" (cause I got the question)
docker/README.md
Outdated
] | ||
``` | ||
|
||
7.clean browser session and cache, login tradenote http://server:7777 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather say, "Login to TradeNote via <your_ip:7777>. If Login fails, clean browser session and cache.
docker/docker-compose.yaml
Outdated
- ALLOW_EMPTY_PASSWORD=yes | ||
|
||
parse: | ||
image: parseplatform/parse-server:5.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just use :latest version here
docker/localdashboard.yaml
Outdated
version: '2' | ||
services: | ||
parse-dashboard: | ||
image: parseplatform/parse-dashboard:4.2.0-alpha.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, I would juste your :latest here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last stable version of parse dashboard has login bug, but fixed in the alpha version
docker/docker-compose.yaml
Outdated
environment: | ||
- ALLOW_EMPTY_PASSWORD=yes | ||
|
||
parse: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it easier for later explanation, I would call this parse-server
docker/docker-compose.yaml
Outdated
@@ -0,0 +1,26 @@ | |||
version: '2' | |||
services: | |||
mongodb: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it easier for later explanation, I would call this parse-mongodb
docker/localdashboard.yaml
Outdated
parse-dashboard: | ||
image: parseplatform/parse-dashboard:4.2.0-alpha.4 | ||
environment: | ||
- PARSE_DASHBOARD_SERVER_URL=http://pi:1337/parse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this generic, "<your_parse_server_ip>/parse" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make another version, save each parameter to a standalone environment file, so users no need to edit the yaml file, users who has less experience with docker will make fewer mistakes
for the comments I didnt reply, I will do it by your way, for those I replied, will need your confirm
No description provided.