Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved plugin search form #79

Merged
merged 1 commit into from
Oct 11, 2014
Merged

Improved plugin search form #79

merged 1 commit into from
Oct 11, 2014

Conversation

PerJensen
Copy link
Contributor

@PerJensen
Copy link
Contributor Author

In this file I noticed all the div#plugin_filters which seems superfluous. Does anyone remember why they are added?

@ewinslow
Copy link
Contributor

Not sure about the other CSS.

This makes me nervous because we are using descendant selectors. We have been trying to avoid location-dependent CSS rules for maintainability.

Do you have before/after screenshots available?

@PerJensen
Copy link
Contributor Author

Before:
search-before
After:
search-after

@ewinslow
Copy link
Contributor

excellent work as always.

I'll let you decide whether its worth cleaning up the CSS. Otherwise, ship it!

@PerJensen
Copy link
Contributor Author

Let's clean up when we decide to go with a major change #65.

PerJensen added a commit that referenced this pull request Oct 11, 2014
@PerJensen
Merge pull request #79 from PerJensen/plugin_search_form
04962f1 
Improved plugin search form
@PerJensen PerJensen merged commit 04962f1 into Elgg:master Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin search form
2 participants
@PerJensen @ewinslow