Skip to content

Commit

Permalink
Keep typeguard back so typechecked works in notebooks
Browse files Browse the repository at this point in the history
This seems to have stopped working in major version 3 (based on
my testing in this project). The current major version of typeguard
is 4. The issue looks like:

agronholm/typeguard#364

This should probably only be a temporary solution. There are other
libraries I could use. But also, it's not obvious that the added
clarity of presentation from defining the top-level functions in
the notebooks that use them, rather than in modules as I would
ordinarily do, is justified, even in the absence of this issue. So
it may be worthwhile to revisit that design decision for codegraph.
But for now I'm keeping that as it is and holding back typeguard.

This commit also updates typing-extensions to the next patch
version.
  • Loading branch information
EliahKagan committed Jun 2, 2023
1 parent b3695ca commit c61c272
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ipykernel = "*"
pygit2 = "*"
pyyaml = "*"
requests = "*"
typeguard = "*"
typeguard = ">=2.13.3,<3"

[dev-packages]
jupyterlab = "*"
Expand Down
22 changes: 11 additions & 11 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c61c272

Please sign in to comment.