Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a new DocAssembler tool #87

Merged
merged 14 commits into from
Dec 16, 2024

Conversation

mtirionMSFT
Copy link
Collaborator

This is a new tool in the family of DocFx Companion Tools. It can be used to assemble documentation and assets from various locations on disk and assemble in one place. The tool will copy and change the links to the new locations of files. It can also change paths and contents using regular expressions. External links (outside of the documentation hierarchy) can be prefixed with a URL.

If the input files are validated with DocLinkChecker, the outcome of DocAssembler will also be validated with DocLinkChecker unless there are configuration errors.

The configuration is done in a JSON file. Everything is documented in the main README. There is also a Test project added with unit tests for all of the functionality.

Copy link
Owner

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All up, looks great! And This is going to definitely be useful for quite some people! Couple of comments, I didn't find anything critical.

src/DocAssembler/README.md Show resolved Hide resolved
src/DocAssembler/README.md Outdated Show resolved Hide resolved
src/DocAssembler/DocAssembler/FileService/Hyperlink.cs Outdated Show resolved Hide resolved
src/DocAssembler/DocAssembler/FileService/Hyperlink.cs Outdated Show resolved Hide resolved
src/DocAssembler/DocAssembler/Actions/ConfigInitAction.cs Outdated Show resolved Hide resolved
src/DocAssembler/README.md Show resolved Hide resolved
src/DocAssembler/README.md Show resolved Hide resolved
src/DocAssembler/README.md Outdated Show resolved Hide resolved
Copy link
Owner

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great addition!

@Ellerbach Ellerbach merged commit 9ecc90b into main Dec 16, 2024
1 check passed
@mtirionMSFT mtirionMSFT deleted the mtirion/new-doc-assembler-tool branch December 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants