Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of heading references in the same file #90

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mtirionMSFT
Copy link
Collaborator

When a markdown file has a reference like (topic)[#topic), it crashed the tool. That is properly handled now including a unit test to validate.

This closes #89

@mtirionMSFT mtirionMSFT added fix Fixed problem DocAssembler labels Dec 19, 2024
Copy link
Owner

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ellerbach Ellerbach merged commit 5a99525 into main Dec 19, 2024
1 check passed
@mtirionMSFT mtirionMSFT deleted the 89-fix-header-ref-same-doc branch January 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocAssembler fix Fixed problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocAssembler: reference a topic in the same file can crash the tool
2 participants