Run more tests regularly in CI. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmuetzel
force-pushed
the
ci
branch
2 times, most recently
from
5b808d0
to
0def071
Compare
The nix workflow takes approx. 30 minutes anyway. So, there is probably little harm in running more tests without extending the overall duration of a CI run by too much.
|
Of the six failing tests on Ubuntu, five are from ElmerIce. I recall that you wrote that some ElmerIce tests are not supposed to pass. (Not sure if I understood that correctly.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nix workflow takes approx. 30 minutes anyway. So, there is probably little harm in running more tests without extending the overall duration of a CI run by too much.