Make work with CMake MUMPS package #536
Conversation
CMP0057 is implicitly NEW by cmake_minimum_required
https://github.com/scivision/mumps this falls back to the custom FindMUMPS of this elmerfem project
| IF(WITH_Mumps) | ||
| FIND_PACKAGE(Mumps REQUIRED) | ||
| ENDIF() | ||
| if(WITH_Mumps) | ||
| find_package(MUMPS CONFIG) | ||
| if(MUMPS_FOUND) | ||
| set(Mumps_FOUND true) | ||
| set(Mumps_LIBRARIES ${MUMPS_LIBRARIES}) | ||
| set(Mumps_INCLUDE_DIR ${MUMPS_INCLUDE_DIRS}) | ||
| if(MUMPS_METIS_FOUND) | ||
| set(Metis_FOUND true) | ||
| set(Metis_LIBRARIES ${METIS_LIBRARIES}) | ||
| set(Metis_INCLUDE_DIR ${METIS_INCLUDE_DIRS}) | ||
| endif() | ||
| else() | ||
| FIND_PACKAGE(Mumps REQUIRED) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
To make this more similar to what is done for a similar situation with UMFPACK or CHOLMOD, would it be possible to move this to FindMumps.cmake?
See, e.g.,
elmerfem/cmake/Modules/FindUMFPACK.cmake
Lines 21 to 26 in 0efbcf3
You'll probably need to move that upper-case to lower-case translation to that file, too.
There was a problem hiding this comment.
As background for why moving that part to FindMumps.cmake would be nice:
Currently, ElmerFEM doesn't install .cmake files. (It only optionally installs pkg-config files.) But if at some point in the future a feature that installs cmake modules alongside ElmerFEM should be integrated, that hunk of logic would need to be repeated wherever those installed .cmake modules would be used in downstream code.
It would be a lot cleaner if that hunk of logic would be integrated in the existing FindMUMPS.cmake file.
|
Thank you for your contribution. |
the Git commits are independent. The first is to allow expected behavior with find_package by setting the maximum policy version to 3.12. This does not affect CMake < 3.12.
The final commit adds logic to work with MUMPS CMake package https://github.com/scivision/mumps that has become a popular way over the past several years to use MUMPS regardless of operating system or compiler or MUMPS options.
This also enables a possible future PR where MUMPS would automatically be downloaded and built if not found.