Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spans to tables #11

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

baszalmstra
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This PR adds complete span information to tables and arrays. It works by keeping track of the spans of KeyValue's and updating the span of the entire table accordingly.

Related Issues

Fixes #10

@Jake-Shadle Jake-Shadle changed the title fix: add spans to tables Add spans to tables Dec 19, 2024
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle Jake-Shadle merged commit 5524274 into EmbarkStudios:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing spans for table names
2 participants