Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an OpenURL event on macOS #1

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rib
Copy link

@rib rib commented Nov 28, 2023

This hooks into the application:openUrls delegate callback on macOS to deliver a corresponding Event::OpenURL to applications.

The event was added as a general Winit event, even though it's only supported for one platform, but potentially we could add some notion of a PlatformEvent to make it more explicit that this is only for macOS.

This enables us to handle users launching an app with an app-specific URL or opening a URL while the app is already running.

@rib rib requested a review from fornwall November 28, 2023 11:39
This hooks into the application:openUrls delegate callback on macOS to deliver
a corresponding Event::OpenURL to applications.

The event was added as a general Winit event, even though it's only supported
for one platform, but potentially we could add some notion of a PlatformEvent
to make it more explicit that this is only for macOS.
@rib rib force-pushed the rib/pr/macos-openurl-winit-0.28 branch from ab25c5d to 5bfddcf Compare November 28, 2023 11:43
@rib rib merged commit bacc95b into ark-staging Nov 28, 2023
12 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants